Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[tool]: reduce docker image size #3120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sambacha
Copy link
Contributor

ignore explicit

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #3120 (0311b5c) into master (7ac2d7c) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
+ Coverage   89.05%   89.17%   +0.12%     
==========================================
  Files          86       84       -2     
  Lines       10792    10765      -27     
  Branches     2449     2453       +4     
==========================================
- Hits         9611     9600      -11     
+ Misses        781      771      -10     
+ Partials      400      394       -6     

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, need some QA to show that the images are equivalent and nothing got ignored that shouldn't be

@charles-cooper
Copy link
Member

this is a dup of #3111

@fubuloubu
Copy link
Member

fubuloubu commented Oct 14, 2022

this is a dup of #3111

I'll say the same thing I said there, hopefully @sambacha confirms or makes an update: I see a few vyper-related files that I would expect to be in the build for it to function properly. That's why it needs some QA to see if it still functions correctly with the slimmed down fileset

specifically:

  1. vyper --version
  2. vyper SomeFile.vy (ensure it has the version pragma in it)
  3. Not sure what other things to check

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this because it doesn't include data that is needed for producing vyper --version output

@sambacha
Copy link
Contributor Author

sambacha commented Apr 9, 2023

Let me update this later today for ya

@charles-cooper charles-cooper changed the title refactor(docker): reduce img size refactor[tool]: reduce docker image size Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants